Thomas Zimmermann <tzimmermann@xxxxxxx> writes: > Move the implementation of fb_pgprotect() to fbdev.c and include > <asm/fb.h>. Fixes the following warning: > > ../arch/x86/video/fbdev.c:14:5: warning: no previous prototype for 'fb_is_primary_device' [-Wmissing-prototypes] > 14 | int fb_is_primary_device(struct fb_info *info) > | ^~~~~~~~~~~~~~~~~~~~ > > Just including <asm/fb.h> results in a number of built-in errors > about undefined function. Moving fb_pgprotect() to the source file > avoids the required include statements in the header. The function > is only called occasionally from fb_mmap(), so having it as static > inline had no benefit. > > While at it, fix the codying style in fbdev.c. > > Link: https://elixir.bootlin.com/linux/v6.3-rc7/source/drivers/video/fbdev/core/fbmem.c#L1404 > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > --- Looks good to me. Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> [...] > base-commit: d2639bb054c42db5ff15c56902d1113303f5b655 > prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > prerequisite-patch-id: cbc453ee02fae02af22fbfdce56ab732c7a88c36 > -- This is a disadvantage of format.useAutoBase = true. I find that have to do `git branch --set-upstream-to=$foo` more often than I would like... At least it seems that patchwork ignores these so that's OK. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
