> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Sent: Mittwoch, 8. März 2023 08:40
> To: Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; Lee Jones
> <lee@xxxxxxxxxx>; Daniel Thompson <daniel.thompson@xxxxxxxxxx>; Jingoo
> Han <jingoohan1@xxxxxxxxx>; Helge Deller <deller@xxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-fbdev@xxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx
> Subject: [PATCH 02/13] backlight: adp5520_bl: Convert to platform remove
> callback returning void
>
> The .remove() callback for a platform driver returns an int which makes many
> driver authors wrongly assume it's possible to do error handling by returning
> an error code. However the value returned is (mostly) ignored and this
> typically results in resource leaks. To improve here there is a quest to make
> the remove callback return void. In the first step of this quest all drivers are
> converted to .remove_new() which already returns void.
>
> Trivially convert this driver from always returning zero in the remove callback
> to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> ---
> drivers/video/backlight/adp5520_bl.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/backlight/adp5520_bl.c
> b/drivers/video/backlight/adp5520_bl.c
> index 686988c3df3a..8e0e9cfe5fe9 100644
> --- a/drivers/video/backlight/adp5520_bl.c
> +++ b/drivers/video/backlight/adp5520_bl.c
> @@ -337,7 +337,7 @@ static int adp5520_bl_probe(struct platform_device
> *pdev)
> return 0;
> }
>
> -static int adp5520_bl_remove(struct platform_device *pdev)
> +static void adp5520_bl_remove(struct platform_device *pdev)
> {
> struct backlight_device *bl = platform_get_drvdata(pdev);
> struct adp5520_bl *data = bl_get_data(bl); @@ -347,8 +347,6 @@
> static int adp5520_bl_remove(struct platform_device *pdev)
> if (data->pdata->en_ambl_sens)
> sysfs_remove_group(&bl->dev.kobj,
> &adp5520_bl_attr_group);
> -
> - return 0;
> }
>
> #ifdef CONFIG_PM_SLEEP
> @@ -377,7 +375,7 @@ static struct platform_driver adp5520_bl_driver = {
> .pm = &adp5520_bl_pm_ops,
> },
> .probe = adp5520_bl_probe,
> - .remove = adp5520_bl_remove,
> + .remove_new = adp5520_bl_remove,
> };
>
> module_platform_driver(adp5520_bl_driver);
> --
> 2.39.1
