On Mon, Aug 22, 2022 at 06:42:48PM -0400, Christopher Carbone wrote: > Adhere to Linux kernel coding style. > > Reported by checkpatch: > > CHECK: multiple assignmentst should be avoided > > Signed-off-by: Christopher Carbone <chris.m.carbone@xxxxxxxxx> > --- > drivers/staging/sm750fb/sm750.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c > index dbd1159a2ef0..6f4c31635cc4 100644 > --- a/drivers/staging/sm750fb/sm750.c > +++ b/drivers/staging/sm750fb/sm750.c > @@ -386,7 +386,8 @@ static int lynxfb_ops_set_par(struct fb_info *info) > > ret = lynxfb_set_color_offsets(info); > > - var->height = var->width = -1; > + var->height = -1; Odd spacing on this new line. Did you run your change through checkpatch? Also, this is a new version of a previously-submitted patch, it needs to be called "v2", and the changes you made from v1 listed below the --- line, as the documentation asks you to do. Please fix this up and submit a v3. thanks, greg k-h
