On Wed, Feb 16, 2022 at 8:26 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote: > The code to set the shifter STe palette registers has a long > standing operator precedence bug, manifesting as colors set > on a 2 bits per pixel frame buffer coming up with a distinctive > blue tint. > > Add parentheses around the calculation of the per-color palette > data before shifting those into their respective bit field position. > > This bug goes back a long way (2.4 days at the very least) so there > won't be a Fixes: tag. > > Tested on ARAnyM as well on Falcon030 hardware. > > Cc: stable@xxxxxxxxxxxxxxx > Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Link: https://lore.kernel.org/all/CAMuHMdU3ievhXxKR_xi_v3aumnYW7UNUO6qMdhgfyWTyVSsCkQ@xxxxxxxxxxxxxx > Tested-by: Michael Schmitz <schmitzmic@xxxxxxxxx> > Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx> Thanks, fixes the issue for me. Tested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
