On Tue, Apr 06, 2021 at 11:36:01PM -0700, Pavle Rohalj wrote:
> Fix "Avoid CamelCase" checkpatch.pl checks for the function dviInit and
> its parameter names in ddk750_dvi.h.
>
> Signed-off-by: Pavle Rohalj <pavle.rohalj@xxxxxxxxx>
> ---
> drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> drivers/staging/sm750fb/ddk750_dvi.h | 20 ++++++++++----------
> 2 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index db19bf732482..943cbcafcffa 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -30,7 +30,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
> #endif
> };
>
> -int dviInit(unsigned char edge_select,
> +int dvi_init(unsigned char edge_select,
Why is this a global function? Just make it static and remove it from
the .h file.
thanks,
greg k-h
