On Wed, Apr 07, 2021 at 09:24:07AM +0200, Greg KH wrote:
> On Tue, Apr 06, 2021 at 11:36:16PM -0700, Pavle Rohalj wrote:
> > Fix "Avoid CamelCase" checkpatch.pl checks for values in
> > enum dpms.
> >
> > Signed-off-by: Pavle Rohalj <pavle.rohalj@xxxxxxxxx>
> > ---
> > drivers/staging/sm750fb/ddk750_power.h | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h
> > index 7002567a47d2..4756db1ccb9c 100644
> > --- a/drivers/staging/sm750fb/ddk750_power.h
> > +++ b/drivers/staging/sm750fb/ddk750_power.h
> > @@ -3,10 +3,10 @@
> > #define DDK750_POWER_H__
> >
> > enum dpms {
> > - crtDPMS_ON = 0x0,
> > - crtDPMS_STANDBY = 0x1,
> > - crtDPMS_SUSPEND = 0x2,
> > - crtDPMS_OFF = 0x3,
> > + CRT_DPMS_ON = 0x0,
> > + CRT_DPMS_STANDBY = 0x1,
> > + CRT_DPMS_SUSPEND = 0x2,
> > + CRT_DPMS_OFF = 0x3,
> > };
>
> And the build does not break with this change? If so, then why are
> these here at all?
>
> thanks,
>
> greg k-h
I do not think so, I was able to build and load the driver with these
changes. It looks like this enum is used as a type of the state parameter of
ddk750_set_dpms function, but the three defined constants are never referenced.
Should we get rid of dpms enum and change the type of the parameter to an unsigned integer?
-Pavle
