Hi Tetsuo, On Sun, Nov 29, 2020 at 07:28:08PM +0900, Tetsuo Handa wrote: > On 2020/11/29 19:03, Thomas Zimmermann wrote: > > Am 28.11.20 um 23:40 schrieb Sam Ravnborg: > >> Replacing DPRINTK() statements with pr_debug fixes set but not used > >> warnings. And moves to a more standard logging setup at the same time. > > > > I guess this was added for quick debugging during development. Anyway, I never liked these kinds of hacks. > > > > Acked-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > > > > But replacing printk(KERN_DEBUG) with pr_debug() prevents __func__ from being printed > when FBCONDEBUG is defined. Is such change what the author of this module expects? When someone goes and enable DEBUG for fbcon they are also able to recognize the logging, so the printing of the function name is redundant in this case. There is likely limited to no use for these few logging entries, but if they should be dropped then I expect Peilin Ye to do so as he is the only one doing active maintenance of fbcon lately. Sam
