[ added dri-devel ML to Cc: ] On 7/7/20 9:47 PM, Dan Carpenter wrote: > On Tue, Jul 07, 2020 at 03:26:03PM -0400, George Kennedy wrote: >> A fb_ioctl() FBIOPUT_VSCREENINFO call with invalid xres setting >> or yres setting in struct fb_var_screeninfo will result in a >> KASAN: vmalloc-out-of-bounds failure in bitfill_aligned() as >> the margins are being cleared. The margins are cleared in >> chunks and if the xres setting or yres setting is a value of >> zero upto the chunk size, the failure will occur. >> >> Add a margin check to validate xres and yres settings. >> >> Signed-off-by: George Kennedy <george.kennedy@xxxxxxxxxx> >> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Suggested-by is perhaps a bit strong. Let's change that to: > > Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Applied to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics