On 2020/07/30 20:16, Daniel Vetter wrote: > Patch looks good, except ... does this compile? fbcon_update_vcs is > defined in fbcon.h, and that doesn't seem to be included here ... > Maybe what we want is an fb_set_var_ioctl in fbmem.c so that the fbcon > interaction is a bit better hidden (but that's a bikeshed, feel free > to ignore). Also I have no idea what trickery you need to compile-test > ps3fb, that's why I'm asking :-) Right. I didn't prepare environment for compiling powerpc kernel. Kernel test robot found it and I already posted V2 patch as https://lkml.kernel.org/r/075b7e37-3278-cd7d-31ab-c5073cfa8e92@xxxxxxxxxxxxxxxxxxx .