Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
Subject: Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 29 Apr 2020 05:51:01 -0700
Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, kbuild test robot <lkp@xxxxxxxxx>, Sam Ravnborg <sam@xxxxxxxxxxxx>, Daniel Vetter <daniel.vetter@xxxxxxxx>, linux-fbdev@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <fe520316-3863-e6c4-9581-5d709f49e906@samsung.com>
References: <CGME20200429104825eucas1p16bf37b71a3ab3a768d1eff6c48eb61dd@eucas1p1.samsung.com> <fe520316-3863-e6c4-9581-5d709f49e906@samsung.com>

Why do we even bother allocing the driver to compile for !ppc32
given that it clearly needs ppc-specific infrastructure?  The whole
idea of needing magic stubs for the COMPILE_TEST case seems rather
counterproduction.

Follow-Ups:
- Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n
  - From: Sam Ravnborg
- Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n
  - From: Bartlomiej Zolnierkiewicz

References:
- [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n
  - From: Bartlomiej Zolnierkiewicz

Prev by Date: Re: [PATCH] video: fbdev: pxa3xx_gcu: Fix some resource leak in an error handling path in 'pxa3xx_gcu_probe()'
Next by Date: Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n
Previous by thread: Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n
Next by thread: Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n
Index(es):
- Date
- Thread

[Index of Archives] [Video for Linux] [Linux USB Devel] [Linux Audio Users] [Yosemite Tourism] [Linux Kernel] [Linux SCSI]