On Sun, Mar 31, 2019 at 06:25:58PM +0100, Sudip Mukherjee wrote: > On Fri, Mar 22, 2019 at 01:17:54PM +0800, Yifeng Li wrote: > > +#define DE_CTRL_COMMAND_SHIFT 16 > > +#define DE_CTRL_COMMAND_BITBLT 0x00 > > +#define DE_CTRL_COMMAND_SOLIDFILL 0x01 > > +#define DE_CTRL_COMMAND_HOSTWRITE 0x08 > > +#define DE_CTRL_ROP2_SELECT 0x00008000 > > +#define DE_CTRL_ROP2_SRC_IS_PATTERN 0x00004000 > > +#define DE_CTRL_ROP2_SHIFT 0 > > +#define DE_CTRL_ROP2_COPY 0x0c > > +#define DE_CTRL_HOST_SHIFT 22 > > +#define DE_CTRL_HOST_SRC_IS_MONO 0x01 > > +#define DE_CTRL_FORMAT_XY 0x00 > > +#define DE_CTRL_FORMAT_24BIT 0x30 > > Please fix the alignment. Some of them are right aligned and some are left. Noted. It will be fixed in PATCH v3. Thanks, Tom Li
