On 02/15/2019 09:25 AM, Geert Uytterhoeven wrote: > On Fri, Feb 15, 2019 at 3:19 AM Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote: >> The value of info->var.bits_per_pixel get checked in macfb_setcolreg(). >> Remove additional checks as they are redundant. >> >> macfb_defined.activate gets initialized to FB_ACTIVATE_NOW by the struct >> initializer. Remove redundant assignments. >> >> macfb_defined.bits_per_pixel, .width and .height all get assigned >> unconditionally. Remove redundant initializers. >> >> Cc: linux-m68k@xxxxxxxxxxxxxxxxxxxx >> Tested-by: Stan Johnson <userm57@xxxxxxxxx> >> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Patch queued for v5.2, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics