Re: [PATCH] fbdev: fsl-diu: remove redundant null check on cmap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wen Yang <wen.yang99@xxxxxxxxxx>, Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
Subject: Re: [PATCH] fbdev: fsl-diu: remove redundant null check on cmap
From: Timur Tabi <timur@xxxxxxxxxx>
Date: Mon, 3 Dec 2018 08:53:53 -0600
Cc: linux-fbdev@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, zhong.weidong@xxxxxxxxxx
In-reply-to: <20181203064317.57054-1-wen.yang99@zte.com.cn>
References: <20181203064317.57054-1-wen.yang99@zte.com.cn>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 12/3/18 12:43 AM, Wen Yang wrote:

The null check on &info->cmap is redundant since cmap is a struct
inside fb_info and can never be null, so the check is always true.
we may remove it.

Signed-off-by: Wen Yang<wen.yang99@xxxxxxxxxx>


Acked-by: Timur Tabi <timur@xxxxxxxxxx>

Follow-Ups:
- Re: [PATCH] fbdev: fsl-diu: remove redundant null check on cmap
  - From: Bartlomiej Zolnierkiewicz

References:
- [PATCH] fbdev: fsl-diu: remove redundant null check on cmap
  - From: Wen Yang

Prev by Date: [PATCH v5] fbdev: Remove depends on HAS_DMA in case of platform dependency
Next by Date: Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE
Previous by thread: [PATCH] fbdev: fsl-diu: remove redundant null check on cmap
Next by thread: Re: [PATCH] fbdev: fsl-diu: remove redundant null check on cmap
Index(es):
- Date
- Thread

[Index of Archives] [Video for Linux] [Linux USB Devel] [Linux Audio Users] [Yosemite Tourism] [Linux Kernel] [Linux SCSI]

Powered by Linux