Daniel Mack <daniel@xxxxxxxxxx> writes:
> + if (fbi->lcd_supply && fbi->lcd_supply_enabled != on) {
Mmh this looks weird ...
If lcd_supply_enabled == on, then the next block is never evaluated, and the
value of "on" is not considered in order to call regulator_disable() ...
> + int ret;
> +
> + if (on)
> + ret = regulator_enable(fbi->lcd_supply);
> + else
> + ret = regulator_disable(fbi->lcd_supply);
This apart, this was a change I was expecting for pxafb, one of the 2 in my
backlog, which is great. The second one was linking a backlight ...
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
