Re: [PATCH v2 3/3] backlight: tdo24m: add model and status sysfs entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Daniel Thompson <daniel.thompson@xxxxxxxxxx> writes:

> On Fri, Oct 13, 2017 at 09:42:49PM +0200, Robert Jarzmik wrote:
>> Add entries to query the panel ASIC to acquire the model number and the
>> status field. This comes in handy to check that the SPI connection is
>> functional and that the panel's firmware is alive.
>> 
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
>
> This feels to me somewhat like debug information being pushed into sysfs.
> There are very few backlight drivers that add additional sysfs attributes
> meaning the extra info here is not commonly pushed into the ABI for a
> backlight and knowing the info in these properties does not really 
> help userspace to *use* the hardware.
>
> Does this kind of thing really belong in sysfs?
Ok, as you wish. Let's drop this patch from the serie for now.

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux