On Mon, Nov 13, 2017 at 02:16:09PM +0000, Daniel Thompson wrote: > On 13/11/17 10:20, Johan Hovold wrote: > > Fix child-node lookup during probe, which ended up searching the whole > > device tree depth-first starting at the parent rather than just matching > > on its children. > > > > To make things worse, the parent mfd node was also prematurely freed. > > > > Note that the nodes returned from the two calls to of_parse_phandle() > > are also leaking, but fixing that is a bit more involved as pointers to > > node fields are being stored for later use. > > Is using a devm_kstrdup() to remember the full_name sufficient so get > each of the FIXMEs cleaned up as well? Yeah, that may be sufficient, but looking closer at this now, it seems the name pointers (su1_fb and su2_fb) are only used as booleans, and the fb_name pointer in struct as3711_bl_data is never used at all. So cleaning that up somehow (e.g. and maybe even dropping non-dt probing) would also work. But since this is a separate, and less critical issue, I think it needs to be done as a follow up to this one. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
