Re: [PATCH -resend 4/6] mdacon: enable COMPILE_TEST build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 3, 2016 at 11:07 AM, Jiri Slaby <jslaby@xxxxxxx> wrote:
> It can be built even on systems without ISA. So enable compile testing
> by specifying ISA || COMPILE_TEST.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> Cc: <linux-fbdev@xxxxxxxxxxxxxxx>
> ---
>  drivers/video/console/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index 38da6e299149..7e9e8be24134 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -48,7 +48,7 @@ config VGACON_SOFT_SCROLLBACK_SIZE
>          screenfuls of scrollback buffer
>
>  config MDA_CONSOLE
> -       depends on !M68K && !PARISC && ISA
> +       depends on !M68K && !PARISC && (ISA || COMPILE_TEST)

My first thought was

    depends on (!M68K && !PARISC && ISA) || COMPILE_TEST

but arch/m68k/include/asm/vga.h doesn't define VGA_MAP_MEM().
Adding #include <asm-generic/vga.h> at the end of arch/m68k/include/asm/vga.h
fixes that.

Do we want that?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux