Hi,
3698d7e7d221 backlight: pwm_bl: Avoid backlight flicker when probed from DT
added support for avoiding backlight flickering, which in essence was designed
to not enable the baclkight when the driver loads, but let the user of the
backlight to enable it later on.
There are boards (like am437x-gp-evm) where we do not have valid GPIO to enable
the backlight (TPS61081DRC's EN pin is connected to V3_3D) and the regulator
is always on (VBAT in case of the gp-evm). In this board the logic to check the
GPIO state and the regulator is failing and the backlight will be enabled as
soon as the pwm_bl driver is loaded.
By extending the check to look at the PWM state this issue can be avoided and
the backlight will be enabled only when it's user is asking it to be enabled.
Note:
I don't know the history of 3698d7e7d221, but I would have opted to add a DT
bool property (default-off) indicating that the given backlight device must stay
off when the driver is probing, other driver will enable it later.
This way all pwm driver could use the same property (gpio-backlight would need
to be converted) and the backward compatibility would have been retained.
Regards,
Peter
---
Peter Ujfalusi (2):
backlight: pwm_bl: Move the checks for initial power state to a
separate function
backlight: pwm_bl: Check the pwm state for initial backlight power
state
drivers/video/backlight/pwm_bl.c | 59 ++++++++++++++++++++++++++--------------
1 file changed, 39 insertions(+), 20 deletions(-)
--
2.10.0
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
