Hi, On 04/09/16 07:26, Stefan Agner wrote: > The lcd-supply is meant to be optional, there are several device- > trees not specifying it and the code handles error values silently. > Therefor, avoid creating a dummy regulator (and the associated > warning) by using devm_regulator_get_optional. > > While at it, document that fact also in the device-tree bindings. The binding change looks correct, but using devm_regulator_get_optional() does not sound correct. devm_regulator_get_optional() is to be used when the device in question truly can function without the power supply. But if the supply is there, it's just not controlled by the SW, devm_regulator_get() is to be used. At least this is my understanding. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
