Re: [PATCH -next] video: fbdev: pxafb: add missing of_node_put() in of_get_pxafb_mode_info()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 13/08/16 11:57, Wei Yongjun wrote:
> This node pointer is returned by of_graph_get_next_endpoint() with
> refcount incremented in this function. of_node_put() on it before
> exitting this function.
> 
> Found by Coccinelle.
> 
> Signed-off-by: Wei Yongjun <weiyj.lk@xxxxxxxxx>
> ---
>  drivers/video/fbdev/pxafb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index ed41fdb..ef73f14 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -2186,6 +2186,7 @@ static int of_get_pxafb_mode_info(struct device *dev,
>  	ret = of_property_read_u32(np, "bus-width", &bus_width);
>  	if (ret) {
>  		dev_err(dev, "no bus-width specified: %d\n", ret);
> +		of_node_put(np);
>  		return ret;
>  	}
> 

Thanks, queued for 4.9.

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux