On Fri, 2016-08-26 at 23:05 -0400, Oleg Drokin wrote: > %ul was probably meant as %lu since the former would print > an unsigned value and a letter l. > > But in fact the whole value we are printing in u32 anyway, so > we don't need the format to be long. Therefore just drop the l > altogether. [] > Also do we really need 1000UL specification if we > cast to u32 anyway? Or should we drop away the cast instead? > Are pixelclocks over 4GHz possible here? It's a debugging printk, it doesn't matter much. Why not use "%u kHz" and drop the "* 1000UL"? > diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c [] > @@ -845,7 +845,7 @@ static int __set_par(struct fb_info *fbi, bool lock) > if (fbi->var.sync & FB_SYNC_SHARP_MODE) > mode = IPU_PANEL_SHARP_TFT; > > - dev_dbg(fbi->device, "pixclock = %ul Hz\n", > + dev_dbg(fbi->device, "pixclock = %u Hz\n", > (u32) (PICOS2KHZ(fbi->var.pixclock) * 1000UL)); > > if (sdc_init_panel(mx3fb, mode, -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
