Hello Tomi, On Tue, May 10, 2016 at 11:47:38AM +0300, Tomi Valkeinen wrote: > On 04/05/16 12:43, Uwe Kleine-König wrote: > > this is v2 of the series which addresses the review comments I got vor > > (implicit) v1. > > > > For patch 2 the question is still open if this is the right fix, but > > without this the display doesn't stay on. Patches 1 and 3 should be > > applicable independant of patch 2. > > I picked patches 1 and 3, they look fine. Thanks. > I still think patch 2 is just broken, it doesn't make sense to me. What do you think should happen during startup? Something should call the set_power callback to enable the device? Or should that only happen when something writes to /dev/fb0? > If the regulator is enabled in probe, then it's always on, and > imxfb_lcd_set_power() should be removed as it never has any effect. But > that doesn't sound correct, as presumably the imxfb_lcd_set_power() has > worked at some point. I think it worked back when unused regulators were not disabled during boot. > And shouldn't the regulator be disabled at least when suspending? Yeah, but maybe the core should call set_power(off) then? (Don't know, maybe that cannot work.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
