On Monday 15 February 2016 16:51:08 Stefano Stabellini wrote: > > > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > index 8ea45a5cd806..fd3d6fd290a9 100644 > > --- a/drivers/video/fbdev/Kconfig > > +++ b/drivers/video/fbdev/Kconfig > > @@ -2241,6 +2241,7 @@ config FB_VIRTUAL > > config XEN_FBDEV_FRONTEND > > tristate "Xen virtual frame buffer support" > > depends on FB && XEN > > + depends on INPUT || !INPUT_MISC > > select FB_SYS_FILLRECT > > select FB_SYS_COPYAREA > > select FB_SYS_IMAGEBLIT > > This looks very hackish. Couldn't we just do the following? > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index 8ea45a5..3c15f6d 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND > select FB_SYS_IMAGEBLIT > select FB_SYS_FOPS > select FB_DEFERRED_IO > - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC > + select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC) > select XEN_XENBUS_FRONTEND > default y > help > No, that doesn't solve the problem: If XEN_FBDEV_FRONTEND=y, INPUT=m and INPUT_MISC=y, we would still get INPUT_XEN_KBDDEV_FRONTEND=y, which cannot work because of INPUT=m. INPUT_MISC already depends on INPUT, so your change has no effect at all. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
