Tomi Valkeinen <tomi.valkeinen@xxxxxx> writes: > On 17/11/15 22:32, Robert Jarzmik wrote: >> This patch brings a first support of pxa framebuffer devices to a >> devicetree pxa platform, as was before platform data. >> >> There are restrictions with this port, the biggest one being the lack of >> support of smart panels. Moreover the conversion doesn't provide a way >> to declare multiple framebuffer configurations with different bits per >> pixel, only the LCD hardware bus width is used. >> >> The patch was tested on both pxa25x, pxa27x and pxa3xx platform (namely >> lubbock, mainstone and zylonite). >> >> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> >> --- >> Since v1: Philipp's review: of_graph usage >> Since v3: of_device_id sentinel, and all compatible ids added >> Since v4: fixed of_device_id table : rebase error on my side, with >> braces which were incorrectly added >> --- >> drivers/video/fbdev/Kconfig | 2 + >> drivers/video/fbdev/pxafb.c | 163 +++++++++++++++++++++++++++++++++++++++++++- >> 2 files changed, 162 insertions(+), 3 deletions(-) > > I see we already have > Documentation/devicetree/bindings/display/marvell,pxa2xx-lcdc.txt in the > mainline. I think the patch adding the binding doc should have been kept > in this series. Ah, I think Rob took it through his tree already. Probably my fault also, I hope I had not forgotten to Cc: you on the binding patch ... > It seems that at least "depth" is missing from the binding document. You're right. Actually depth is not a "hardware" caracteristic. Moreover it's just used as an overlay for pxafb_set_pixfmt() to superseed var->bits_per_pixel. I'm wondering if the right path for of_get_pxafb_mode_info() would be to remove completely depth, and leave it initialized at 0 for the DT case. What do you think of this approach ? The other one would be to modify the binding, and yet I feel this depth doesn't belong to the binding, it's my patch which requires another spin IMHO. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
