On 25/11/15 05:11, Ezequiel Garcia wrote: > There's no point in having support for framebuffer notifications > is CONFIG_FB is disabled. This commit adds the necessary stubs > for code to link properly when CONFIG_FB=n and moves fb-notify.o > to be built only when CONFIG_FB=y. Why do you add CONFIG_FB_NOTIFY, isn't plain CONFIG_FB enough? Oh, right, to have it built-in even if FB is a module. But this makes me wonder, why is fb_notify in obj-y list currently. Nobody just bothered to make it build only when needed, or has there been some use for it earlier... The commit descriptions in git history suggest the former. Actually, looks like fb_notify.c was originally made to solve the same problem as your patch solves, but by separating the notify code from the main fbdev code. So I still wonder, was there some reason to keep the notification code built instead of having stub functions. Any thoughts? Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
