Hi Lee, Am Freitag, den 30.10.2015, 18:21 +0000 schrieb Lee Jones: > > @@ -264,12 +266,32 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > pb->enable_gpio = gpio_to_desc(data->enable_gpio); > > } > > > > + phandle = of_find_property(pdev->dev.of_node, "phandle", NULL) != NULL; > > This is a little ugly. > > If this is the only way to identify the probedness of a device then > you probably want to neaten it up a little. I suggest something along > the lines of: > > if (of_find_property(pdev->dev.of_node, "phandle", NULL)) > already_probed = true; > > Also, do you also want to check for "linux,phandle", as this is always > catered for in drivers/of/* Thanks for pointing this out. I suppose I should just check pdev->dev.of_node->phandle != 0 instead. That will already be initialized by unflatten_dt_node if either property was found. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
