On Fri, 2015-10-16 at 10:36 +0200, Sascha Hauer wrote: > On Fri, Oct 16, 2015 at 09:37:34AM +0800, YH Huang wrote: > > In order to match the panel power sequence, disable the enable_gpio > > in the probe function. Also, reorder the code in the power_on and > > power_off function to match the timing. > > @@ -241,8 +242,7 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > pb->dev = &pdev->dev; > > pb->enabled = false; > > > > - pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable", > > - GPIOD_OUT_HIGH); > > + pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable"); > > Please actually test your patches. This change here won't compile. > > Sascha > I will send patch v2 to fix it. YH Huang -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html