On 08/09/15 17:04, Jacek Anaszewski wrote: >>> +#endif /* __LINUX_LEDS_OF_H_INCLUDED */ >>> diff --git a/include/linux/leds.h b/include/linux/leds.h >>> index b122eeafb5dc..0fce71a06d68 100644 >>> --- a/include/linux/leds.h >>> +++ b/include/linux/leds.h >>> @@ -113,6 +113,8 @@ extern void devm_led_classdev_unregister(struct >>> device *parent, >>> extern void led_classdev_suspend(struct led_classdev *led_cdev); >>> extern void led_classdev_resume(struct led_classdev *led_cdev); >>> >>> +extern void led_put(struct led_classdev *led_cdev); >>> + > > This also needs no-op version. Ok, but... I think other already existing functions need no-ops also. If there's a driver that uses of_led_get and led_put, it's sure to use some other led_* functions also. So if we want that driver to be compilable when LED support is disabled in the kernel, we need to provide no-ops for all those functions. Probably: led_set_brightness led_blink_set_oneshot led_blink_set Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
