On Thu, Jun 18, 2015 at 3:01 PM, Marcin Chojnacki <marcinch7@xxxxxxxxx> wrote:
> In vfb_probe memory is allocated using rvmalloc which automatically
> sets the allocated memory to zero. This patch removes the second
> unnecessary memset in vfb_probe.
>
> Signed-off-by: Marcin Chojnacki <marcinch7@xxxxxxxxx>
> ---
> drivers/video/fbdev/vfb.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/video/fbdev/vfb.c b/drivers/video/fbdev/vfb.c
> index 70a897b..b2d38b7 100644
> --- a/drivers/video/fbdev/vfb.c
> +++ b/drivers/video/fbdev/vfb.c
> @@ -490,14 +490,6 @@ static int vfb_probe(struct platform_device *dev)
> if (!(videomemory = rvmalloc(videomemorysize)))
> return retval;
>
> - /*
> - * VFB must clear memory to prevent kernel info
> - * leakage into userspace
> - * VGA-based drivers MUST NOT clear memory if
> - * they want to be able to take over vgacon
> - */
> - memset(videomemory, 0, videomemorysize);
> -
As vfb also serves as a sample driver, I think it would be worthwhile to move
the comment to rvmalloc().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
