On Tue, Apr 21, 2015 at 2:09 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxx> wrote: > On Tue, Apr 21, 2015 at 1:59 PM, Marciniszyn, Mike > <mike.marciniszyn@xxxxxxxxx> wrote: >>> > This driver already makes use of ioremap_wc() on PIO buffers, so >>> > convert it to use arch_phys_wc_add(). >>> >>> This is probably OK, but I think you should also remove the qib_wc_pat module >>> parameter. >>> >>> Jason >> >> Revise based on Jason's request and I will do some testing. > > I did thiink about this -- but removal of module parameters can often > times break users of the module parameter, I figured its best to leave > it to you guys to decide what to do with that, so this leaves it as a > no-op. Can this series be applied and then you can decide what to do > to not affect your users on top of this? As of a few kernel versions ago, unrecognized module parameters no longer cause the module to refuse to load. --Andy > > Luis -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
