On 24/02/15 22:31, NeilBrown wrote: > On Tue, 24 Feb 2015 12:40:32 +0200 Tomi Valkeinen <tomi.valkeinen@xxxxxx> > wrote: > >> Hi, >> >> On 24/02/15 11:37, NeilBrown wrote: >>> >>> >>> commit 303e4697e762dc92a40405f4e4b8aac02cd0d70b >>> OMAPDSS: rename display-sysfs 'name' entry >>> >>> broke the xorg X server on my device as it couldn't find the display >>> any more. It needs the 'name' file and now there isn't one. >>> >>> That commit claims that 'name' is not compatible with i2c or spi. >>> i2c does register it own 'name' file, but spi does not, hence my >>> problem - I have an spi display. >>> >>> So create a special case for i2c: add the name attribute for non-i2c >>> devices. >> >> What X driver is that? What's it doing with the display name? Is it just >> using the display name to show something for the user, and the returned >> value can be essentially any string? >> >> Tomi >> >> > /usr/lib/xorg/modules/drivers/omapfb_drv.so > from package xserver-xorg-video-omap3 in Debian. > > I don't know where the main upstream source is, but here: > > https://gitorious.org/gnutoo-s-programs-for-shr/xf86-video-omapfb/source/28c006c94e57ea71df11ec4fff79d7ffcfc4860f:src/omapfb-output-dss.c#L258 > > is the code which reads > /sys/devices/platform/omapdss/display0/name > and fails if that file cannot be opened. Thanks. Unfortunately it looks to me that the omapfb_drv uses the display name to configure things, and as in i2c's case the 'name' is not the correct dss name, X will probably fail in interesting ways. Of course, it's already broken in that way, so this fix improves the situation for non-i2c displays. I'll have a look if I can figure out how to fix this for all displays. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
