On Fri, Feb 13, 2015 at 01:36:18PM +0000, Russell King - ARM Linux wrote: > On Fri, Feb 13, 2015 at 08:28:10AM -0500, Parmeshwr Prasad wrote: > > > > This is second patch in series. > > In driver in_atomic we should not use to check if code is unning in IRQ. > > clcdfb_sleep() function is used to give some delay between operation. > > I have used schedule_timeout() function for same amount of delay. > > Frankly, this patch is a mess. It seems to contain unrelated changes. and this patch is corrupted. your commit message is a mess and the maintainer has to edit it by hand before applying. if i remember correctly you have been told multiple times by many people to fix your commit message. and try to use git send-email to send your patches. regards sudip > > Please always review your own patches before you send them - this will > allow you to catch such errors before you post them publically. > > The change to clcdfb_sleep() is wrong in any case - you will end up > calling schedule_timeout() from illegal contexts (eg, when the > framebuffer gets blanked/unblanked.) > > -- -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
