On Fri, Feb 13, 2015 at 03:59:56AM -0800, Joe Perches wrote: > Perhaps this could be better as: > > fb->fb.fix.smem_start = > of_translate_address(memory, > of_get_address(memory, 0, &size, NULL)); > > But sometimes using multiple statements instead of > embedding function calls as arguments can be simpler > and more intelligible for the reader. > > __be32 addr; > > ... > > addr = of_get_address(memory, 0, &size, NULL); > fb->fb.fix.smem_start = of_translate_address(memory, addr); Yes, that would be a better solution, thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html