Hi Kevin, On Sun, 1 Feb 2015 13:51:50 +0800 Kevin Hao <haokexin@xxxxxxxxx> wrote: > > That was my first thought, but the codes protected by the PPC_OF seem not > ppc specific and should be safe for other archs which also support OF. So I > drop the PPC_OF completely. Did I miss something? Ah, ok. > > > dp = pci_device_to_OF_node(pdev); > > > @@ -1478,7 +1477,6 @@ static int imsttfb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > > > printk(KERN_INFO "%s: OF name %s\n",__func__, dp->name); > > > else > > > printk(KERN_ERR "imsttfb: no OF node for pci device\n"); > > > -#endif /* CONFIG_PPC_OF */ > > > > This will emit the above error if CONFIG_OF is not set whereas in the > > past it would not. > > How about change it to: > if (IS_ENABLED(CONFIG_OF)) > printk(KERN_ERR "imsttfb: no OF node for pci device\n"); Looks good. -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
Attachment:
pgpYK2Z8dRIcu.pgp
Description: OpenPGP digital signature
