Hi, Thanks for doing this, On Wed, Jan 14, 2015 at 08:24:49AM +0000, Lad, Prabhakar wrote: > this patch fixes ssd1307fb_ssd1306_init() function to return > proper error codes in case of failures. > > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> > --- > drivers/video/fbdev/ssd1307fb.c | 54 ++++++++++++++++++++++++++++++----------- > 1 file changed, 40 insertions(+), 14 deletions(-) > > diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c > index f4daa59..528ea16 100644 > --- a/drivers/video/fbdev/ssd1307fb.c > +++ b/drivers/video/fbdev/ssd1307fb.c > @@ -320,7 +320,9 @@ static int ssd1307fb_ssd1306_init(struct ssd1307fb_par *par) > > /* Set initial contrast */ > ret = ssd1307fb_write_cmd(par->client, SSD1307FB_CONTRAST); > - ret = ret & ssd1307fb_write_cmd(par->client, 0x7f); > + if (ret < 0) > + return ret; A newline here (and to all the subsequent changes) would be great. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
