On 23/12/14 02:27, David Ung wrote: > fbmon may generate mode timings that are out of spec of the monitor. > eg DELL U2410 has a max clock 170mhz but advertises a resolutions of > 1920x1200@60 in its Standard Timings using 2byte code of D1 00. > When this is looked up in the DMT table it gives it a 193mhz clock. > Although the DELL monitor supports 1920x1200@60, it can only run with > reduced timings at 154mhz or DMT id 0x44 which has no STD 2byte code. > This patch checks to see if the mode can be supported by the monitor > by comparing against monspecs.dclkmax. > > Signed-off-by: David Ung <davidu@xxxxxxxxxx> > --- > drivers/video/fbdev/core/fbmon.c | 27 ++++++++++++++++++--------- > 1 file changed, 18 insertions(+), 9 deletions(-) > > diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c > index aa1110a..cc3ea6c8 100644 > --- a/drivers/video/fbdev/core/fbmon.c > +++ b/drivers/video/fbdev/core/fbmon.c > @@ -496,7 +496,7 @@ static int get_est_timing(unsigned char *block, struct fb_videomode *mode) > } > > static int get_std_timing(unsigned char *block, struct fb_videomode *mode, > - int ver, int rev) > + int ver, int rev, struct fb_monspecs *specs) Here and in the rest of the functions I believe monspecs is never supposed to be changed, so it should be marked as const. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
