On Thu, Dec 11, 2014 at 5:41 AM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote: > > Please pull fbdev changes for 3.19. Ugh. I've pulled it, but I'm not a huge fan of commit 6d09dc6b74ca ("of.h: Keep extern declaration of of_* variables when !CONFIG_OF"). I guess it works, but it ends up delaying any failures from compile time to link time, and the linker error messages likely won't be great. So I'm cc'ing the OF people and Rafael (who worked on OF/ACPI unification) to see if they have comments, preferences, or other ways to solve this. Quite frankly, to me it smells like non-OF builds should just have an empty "for_each_child_of_node ()" define instead of playing games with externs that then end up not existing, and depending on the compiler DTRT. Comments? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html