On Wed, Dec 3, 2014 at 6:11 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Tuesday 02 December 2014 17:39:12 Sean Paul wrote: >> >> .../devicetree/bindings/video/backlight/lp855x.txt | 2 ++ >> drivers/video/backlight/lp855x_bl.c | 18 ++++++++++++++++++ >> include/linux/platform_data/lp855x.h | 2 ++ >> 3 files changed, 22 insertions(+) > > While your two patches are both correct (and applied already), I took > a look at the platform_data header and noticed that all users of this > file have been converted to DT a while ago, so it would be nice to clean > it up by integrating the linux/platform_data/lp855x.h header file into the > drivers/video/backlight/lp855x_bl.c itself. > > You can then merge struct lp855x_platform_data into lp855x to avoid the > extra dynamic allocation and remove all the 'pdata' references in the > driver. > Hi Arnd, Thanks for the suggestion. Indeed, that will be much cleaner, I'll send a follow-up patch. Sean > Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
