Hi Tomi, Thanks very much for your comments. > Subject: Re: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs > > Hi, > > On 05/09/14 07:48, Xiubo Li wrote: > > Some Freescale SoCs, there has an DVI/HDMI controller and a PHY, > > attached to one of their display controller unit's LCDC interfaces. > > This patch adds a preliminary static support for such controllers. > > > > This will support for many modes and a dynamic switching between > > them. > > > > Signed-off-by: Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/video/fsl-sii902x.txt | 17 + > > drivers/video/fbdev/Kconfig | 7 + > > drivers/video/fbdev/Makefile | 1 + > > drivers/video/fbdev/fsl-sii902x.c | 526 > +++++++++++++++++++++ > > 4 files changed, 551 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/video/fsl-sii902x.txt > > create mode 100644 drivers/video/fbdev/fsl-sii902x.c > > I don't know how you picked the names of the people you sent this patch > to, but looks to me that most of them are probably not interested in > this patch. > I just using the get_maintainer.pl script. > Anyway, a few quick comments on the patch: > > - You should probably use regmap instead of direct i2c calls. > Interestingly, you define regmap variable, but you never use it. Yes, this it's my another version in my local machine using regmap which need much more test. > - Use defines for register offsets, instead of magic numbers. This will be fixed together with regmap using. > - You should not use static variables. They prevent having multiple > instances of the device. > Okay. > So the SiI902x chip is on the SoC, not on the board? And it's a plain > standard SiI902x in other aspects? > No, it's on board. And it will be used for i.MX and LS1+ platforms. Thanks, BRs Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
