Hi On Wed, Aug 13, 2014 at 10:46 AM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > On Wed, Aug 13, 2014 at 9:25 AM, David Herrmann <dh.herrmann@xxxxxxxxx> wrote: >>> @@ -225,7 +234,7 @@ static int simplefb_probe(struct platform_device *pdev) >>> framebuffer_release(info); >>> return -ENODEV; >>> } >>> - info->pseudo_palette = (void *)(info + 1); >>> + info->pseudo_palette = (void *) par->palette; >> >> I think coding-style is this (i.e., no whitespace): >> info->pseudo_palette = (void*)par->palette; > > <casts-are-evil> > Is this cast even needed? > </casts-are-evil> "pseudo_palette" is "void*", so not at all. Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
