2014-07-07 12:46 GMT+02:00 Lee Jones <lee.jones@xxxxxxxxxx>: >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx> >> --- >> drivers/video/backlight/jornada720_lcd.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) > > Solve it the other way around. > > Add a check and return the value if an error is returned. Hi Ok, I take the opportunity to make a bigger change to clarify the similarities in function. Hope you like it, otherwise I can make the minor change instead. Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html