Re: [PATCH v2 1/2] video: clps711x: Add new Cirrus Logic CLPS711X framebuffer driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 19 June 2014, Alexander Shiyan wrote:
> -config FB_CLPS711X
> -       bool "CLPS711X LCD support"
> -       depends on (FB = y) && ARM && ARCH_CLPS711X
> +config FB_CLPS711X_OLD
> +       bool
>         select FB_CFB_FILLRECT
>         select FB_CFB_COPYAREA
>         select FB_CFB_IMAGEBLIT
> +
> +config FB_CLPS711X
> +       tristate "CLPS711X LCD support"
> +       depends on FB && (ARCH_CLPS711X || COMPILE_TEST)
> +       select FB_CLPS711X_OLD if ARCH_CLPS711X && !ARCH_MULTIPLATFORM
> +       select BACKLIGHT_LCD_SUPPORT
> +       select FB_MODE_HELPERS

I found that with this change, you can now end up in a situation of CONFIG_FB=m
and FB_CLPS711X=y, which doesn't link properly.

We need to either turn FB_CLPS711X_OLD into 'tristate' or add
'depends on ARCH_MULTIPLATFORM || FB=y' to FB_CLPS711X.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux