Re: [PATCH 4/4] ARM: dts: Add LCD panel sharp ls037v7dw01 support for omap3-evm and ldp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Tomi Valkeinen <tomi.valkeinen@xxxxxx> [140521 05:45]:
> On 14/05/14 00:32, Tony Lindgren wrote:
> 
> > +&dss {
> > +	status = "ok";
> > +	vdds_dsi-supply = <&vpll2>;
> > +	port {
> > +		dpi_out: endpoint {
> > +			remote-endpoint = <&lcd_in>;
> > +			data-lines = <18>;
> > +		};
> > +	};
> > +};
> 
> I just noticed the vdds_dsi-supply there. While the driver currently
> uses that if available, I think it should be removed, and done the same
> way Florian did with his overo patches:
> 
> /* Needed to power the DPI pins */
> &vpll2 {
> 	regulator-always-on;
> };
> 
> That supply is not DSS's supply, but it's used to power up the pins. If
> the pins were used as GPIOs, that power should be enabled.

OK thanks for catching it.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Tourism]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux