Thu, 24 Apr 2014 11:39:21 +0300 от Tomi Valkeinen <tomi.valkeinen@xxxxxx>: > On 24/04/14 11:10, Alexander Shiyan wrote: > > Hello. > > > > Thu, 24 Apr 2014 10:57:59 +0300 от Tomi Valkeinen <tomi.valkeinen@xxxxxx>: > >> Hi, > >> > >> On 12/04/14 09:53, Alexander Shiyan wrote: > >>> This adds support for the framebuffer available in the Cirrus > >>> Logic CLPS711X CPUs. > >>> FB features: > >>> - 1-2-4 bits per pixel. > >>> - Programmable panel size to a maximum of 1024x256 at 4 bps. > >>> - Relocatible Frame Buffer (SRAM or SDRAM). > >>> - Programmable refresh rates. > >>> - 16 gray scale values. > >>> This new driver supports usage with devicetree and as a general > >>> change it removes last user of <mach/hardware.h> for CLPS711X targets, > >>> so this subarch will fully prepared to switch to multiplatform. > >>> The driver have been tested with custom board equipped Cirrus Logic > >>> EP7312 in DT and non-DT mode. > >> > >> My original comment about this is still unanswered: why a totally new > >> driver? The proper way would be to gradually change the old driver with > >> a patch series. Then it's possible to review the patches and see what is > >> actually changed. > > > > I have tried to answer here: > > http://www.spinics.net/lists/linux-fbdev/msg14218.html > > If your answer means "it will be very difficult to see the changes if > all the changes are in one patch, which change the old driver in one > go", then yes, very true. > > But that's wrong way to do it. > > The right way to do it is, as I wrote above, by gradually changing the > old driver with a patch series. And my question is, why not do it that > way? Then it would be possible to review the patches one by one, seeing > what has changed. "gradually changing"... I repeat that this is not an old modified driver, but written new. if you imagine a new file as a diff to the old, this can be clearly seen. There is no reason to waste time on a series of changes since I can not even check these changes on real hardware, but only in the last stage when the driver will be the current version. --- ��.n��������+%������w��{.n�����{����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
