On Thursday 24 April 2014 13:32:35 Russell King - ARM Linux wrote: > On Thu, Apr 24, 2014 at 01:28:19PM +0100, Peter Griffin wrote: > > From: Arnd Bergmann <arnd@xxxxxxxx> > > > > We can only use I2C support in frame buffer drivers if > > Either I2C is built-in, or both I2C and the driver itself > > are loadable modules. > > Why? If I2C is a loadable module, and the I2C support of the framebuffer driver is built-in, you get a link error when building vmlinux: drivers/built-in.o: In function `cyberpro_pci_remove': :(.text+0x1ea5c): undefined reference to `i2c_del_adapter' drivers/built-in.o: In function `cyberpro_pci_probe': :(.text+0x20224): undefined reference to `i2c_bit_add_bus' :(.text+0x20240): undefined reference to `i2c_del_adapter' make[2]: *** [vmlinux] Error 1 It's probably a good idea to mention that in the changeset text. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
