On Wednesday, April 02, 2014 8:15 PM, Dan Carpenter wrote:
>
> Hello Daniel Mack,
>
> The patch a9b47c7f2390: "video: pxa3xx-gcu: switch to devres
> functions" from Mar 5, 2014, leads to the following static checker
> warning:
>
> drivers/video/fbdev/pxa3xx-gcu.c:616 pxa3xx_gcu_probe()
> warn: 'priv->mmio_base' isn't an ERR_PTR
>
> drivers/video/fbdev/pxa3xx-gcu.c
> 612
> 613 /* handle IO resources */
> 614 r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> 615 priv->mmio_base = devm_request_and_ioremap(dev, r);
> 616 if (IS_ERR(priv->mmio_base)) {
>
> devm_request_and_ioremap() returns NULL on error.
Yes, you're right.
It should be replaced with devm_ioremap_resource().
I will send the patch, soon.
Best regards,
Jingoo Han
>
> 617 dev_err(dev, "failed to map I/O memory\n");
> 618 return PTR_ERR(priv->mmio_base);
> 619 }
> 620
>
> regards,
> dan carpenter
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
