> @@ -1752,6 +1793,22 @@ static int fsl_diu_probe(struct platform_device *pdev) > goto error; > } > > + if (!diu_ops.set_pixel_clock) { > + data->pixelclk_reg = of_iomap(np, 1); > + if (!data->pixelclk_reg) { > + dev_err(&pdev->dev, "Cannot map pixelclk registers, please \ > + provide the diu_ops for pixclk setting instead.\n"); The error message should be in one line if possible, or it will hard to grep. If cannot, should split it into two or more lines, like: + dev_err(&pdev->dev, "Cannot map pixelclk registers,\n" + "please provide the diu_ops for pixclk setting instead.\n"); Thanks, BRs Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html