Hello.
Wed, 19 Mar 2014 15:31:49 +0200 от Tomi Valkeinen <tomi.valkeinen@xxxxxx>:
> Hi,
>
> On 14/03/14 13:09, Alexander Shiyan wrote:
> > Provide dummy functions for LCD register()/unregister() if
> > CONFIG_LCD_CLASS_DEVICE is not set.
> > This allows us to use the LCD class as an optional.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> > ---
> > include/linux/lcd.h | 37 ++++++++++++++++++++++++++++++-------
> > 1 file changed, 30 insertions(+), 7 deletions(-)
>
> I'm still not convinced about this. Isn't it simpler to just
> select/depend on LCD_CLASS_DEVICE? The lcd.c is a bit less than 9 kB, so
> it's not like you're adding a huge amount of code into the kernel even
> if the driver doesn't happen to use it for a particular display.
Ie we prefer to increase the size of the kernel, even for functions which are optional?
OK, I'll post a patch for the imxfb driver which selects LCD_CLASS unconditionally.
Nevertheless, the current patch is still valid for review.
Thanks.
---
��.n��������+%������w��{.n�����{����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
