Hi, On 03/02/14 19:14, Uwe Kleine-König wrote: > This patch makes mmapping the simple-framebuffer device work on a no-MMU > ARM target. The code is mostly taken from > arch/blackfin/kernel/sys_bfin.c. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > Hello, > > note this is only tested on this no-MMU machine and I don't know enough > about framebuffers and mm to decide if this patch is sane. Also I'm > a bit unsure about the size check, I just believed Geert that > PAGE_ALIGN(info->fix.smem_len) is the right value to check against. I don't know enough about mm to say much here, and the text above make me feel a bit uneasy. I'd be happy if this would get a few acks/reviewed-bys/tested-bys... So what does this patch actually do? If I read things correctly, currently .get_unmapped_area is null, except for sparc and blackfin. But userspace's mmap() calls that, right? Is there a default implementation somewhere? Why is that different for no-MMU case? Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
