Пятница, 14 марта 2014, 10:12 +01:00 от Denis Carikli <denis@xxxxxxxxxx>: > This commit is based on the following commit by Fabio Estevam: > 4344429 video: mxsfb: Introduce regulator support > > Signed-off-by: Denis Carikli <denis@xxxxxxxxxx> > --- ... > + if (np) { > + if (regulator_name) > + mx3fbi->reg_lcd = regulator_get(NULL, regulator_name); > + > + if (IS_ERR(mx3fbi->reg_lcd)) > + return PTR_ERR(mx3fbi->reg_lcd); > + } else { > + /* Permit that driver without a regulator in non-dt mode */ > + mx3fbi->reg_lcd = regulator_get(dev, "lcd"); > + } I am still completely do not understand why do you need to have "regulator_name" property? Why this cannot be devm_regulator_get(dev, "lcd") in both DT and non-DT case? --- ��.n��������+%������w��{.n�����{����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�